1 decade ago by lachsen
Hi there,
not entirely sure, if that belongs here.
Anyway, I found a bug in impact.js concerning the constructor property.
in impact.js around line 483, the code is:
Class.prototype = prototype;
Class.constructor = Class;
However, the assignment of the constructor property doesn't work like this.
In practice, all classes derived with Class.extend have the same constructor.
The constructor property needs to be assigned to the prototype instead:
Class.prototype = prototype;
Class.prototype.constructor = Class;
I just wanted to mention this bug, since it's deep down in the basis.
Well, I just found this out recently, since you don't use the constructor property that often, really...
Anyway, that's all.
C ya
Lachsen
not entirely sure, if that belongs here.
Anyway, I found a bug in impact.js concerning the constructor property.
in impact.js around line 483, the code is:
Class.prototype = prototype;
Class.constructor = Class;
However, the assignment of the constructor property doesn't work like this.
In practice, all classes derived with Class.extend have the same constructor.
The constructor property needs to be assigned to the prototype instead:
Class.prototype = prototype;
Class.prototype.constructor = Class;
I just wanted to mention this bug, since it's deep down in the basis.
Well, I just found this out recently, since you don't use the constructor property that often, really...
Anyway, that's all.
C ya
Lachsen